Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes jam #208

Merged
merged 3 commits into from
Aug 25, 2021
Merged

Removes jam #208

merged 3 commits into from
Aug 25, 2021

Conversation

ForestEckhardt
Copy link
Contributor

  • Removes jam from cargo
  • Removes scripts directory as the only scripts was a packaging script
    for jam
  • Removes jam packaging from release workflow

Addresses part of #207

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@ForestEckhardt ForestEckhardt requested a review from a team as a code owner July 23, 2021 15:10
@ForestEckhardt ForestEckhardt marked this pull request as draft July 23, 2021 15:10
@fg-j
Copy link

fg-j commented Aug 10, 2021

Hey @ForestEckhardt - is there a specific reason why this is still in draft?

@ForestEckhardt
Copy link
Contributor Author

@fg-j I am trying to follow the steps I laid out in issue #207. I would like to have the new jam repo completely up and running before I remove the code from this repo. My hope is to have this done by the end of the week but we shall see if that dream boat holds water.

@ForestEckhardt ForestEckhardt marked this pull request as ready for review August 23, 2021 13:41
ryanmoran
ryanmoran reviewed Aug 23, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@ryanmoran
Copy link
Member

The commit history looks pretty wonky. Can you also rebase this?

@ForestEckhardt @ryanmoran
Removes jam
3541ef0 
- Removes `jam` from `cargo`
- Removes `scripts` directory as the only scripts was a packaging script
for `jam`
- Removes `jam` packaging from release workflow

Co-authored-by: Ryan Moran <155736+ryanmoran@users.noreply.github.com>
@fg-j
Copy link

fg-j commented Aug 24, 2021

@ForestEckhardt looks like something funky happened with the commit authors on the most recent commit

fg-j
fg-j reviewed Aug 24, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
Frankie Gallina-Jones and others added 2 commits August 24, 2021 10:55
don't gitignore dir where jam was built
1eae09b
@ForestEckhardt
Update README.md
2ba20d4 
Co-authored-by: Frankie G-J <frankieg@vmware.com>
@ForestEckhardt
Copy link
Contributor Author

@fgj It looks like it just an Ubuntu user from the merge. Do you want me to go in and reset the authors?

@fg-j
Copy link

fg-j commented Aug 24, 2021

@ForestEckhardt That would be cool, but I won't block on it.

@fg-j fg-j self-requested a review August 24, 2021 20:22
@fg-j
Copy link

fg-j commented Aug 24, 2021

@ryanmoran do you have other outstanding concerns here?

@ryanmoran
Copy link
Member

@fg-j nope. LGTM

@fg-j fg-j merged commit f232e3e into main Aug 25, 2021
@fg-j fg-j deleted the remove-jam branch August 25, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fg-j fg-j fg-j approved these changes

@ryanmoran ryanmoran ryanmoran approved these changes

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ForestEckhardt @fg-j @ryanmoran