Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return dependency mapping error to Deliver() caller #221

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

fg-j
Copy link

@fg-j fg-j commented Aug 27, 2021

Summary

Resolves #220

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@fg-j fg-j requested a review from a team as a code owner August 27, 2021 17:57
@fg-j fg-j changed the title expose dependency mapping error to caller expose dependency mapping error to Deliver() caller Aug 27, 2021
@fg-j fg-j changed the title expose dependency mapping error to Deliver() caller return dependency mapping error to Deliver() caller Aug 27, 2021
@ForestEckhardt ForestEckhardt merged commit f0fe48c into main Aug 30, 2021
@ForestEckhardt ForestEckhardt deleted the return-binding-error branch August 30, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packit/postal/service.go - Possibly eating error info?
2 participants