-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate non-specification field #230
Conversation
It may not appear to be used in |
Interesting because as far as I can figure from the spec the buildpack table has no SHA field. I'll take a look! |
Its not used to read out a value from the |
@ryanmoran Here is a PR to remove the use of the |
Are you planning to bump the major version of |
I hadn't really thought about how I would classify the bump. I think that by definition it would have to be but the field was never parsed it was just part of the structure. It feels a little silly to have a major bump over such a small change. |
Yes. But strictly speaking, its a backwards-incompatible change. Maybe you should leave the field and just mark it as deprecated which is what we have done in the past. Then, when we get to a point where a major version bump feels warranted because of other, more substantial changes, we can remove it. |
I think that is fair. We can still go forward with the Jam change as well. |
b64b58d
to
6a5d20c
Compare
Checklist