-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors out common Checksum concept #399
Conversation
I can't comment on it directly for some reason, but there is a linting error in postal/service.go to remove function |
Also, this seems like a reasonable change but I wanted to point out that introducing the new Checksum type will be breaking for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple nitpicks/clarifications. But overall, LGTM!
Good catch. I meant to remove this. |
Ok. I rolled back the changes that might have been breaking. We still use |
Summary
We have some common code for splitting and comparing checksums across
cargo
andpostal
. This factors those pieces out into a common place.Checklist