Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume PHP dependency from the dep-server #255

Closed
arjun024 opened this issue Jul 9, 2021 · 1 comment · Fixed by #293
Closed

Consume PHP dependency from the dep-server #255

arjun024 opened this issue Jul 9, 2021 · 1 comment · Fixed by #293

Comments

@arjun024
Copy link
Member

arjun024 commented Jul 9, 2021

Per paketo-buildpacks/dep-server#45, we should start consuming the PHP dependency from the dep-server (https://api.deps.paketo.io/v1/dependency?name=<dependency>) instead of the https://buildpacks.cloudfoundry.org/dependencies/<dependency>/... location we currently get the dependencies from.

This will make the dependency publishing/consumption process more transparent than the process we use for the dependencies available via the dependency-builds pipeline.

We have already done this switch-over in the Node Engine and Yarn Buildpacks. The outline of what this work will entail can be found in the dep-server issue linked at the top.
@sophiewigmore
Copy link
Member

Should we hold off on this until paketo-buildpacks/dep-server#30 is implemented?

arjun024 added a commit that referenced this issue Sep 27, 2021
@arjun024
Use repackaged php dependency, use dep-server, new packit
b7a8430 
Fixes: #253
Fixes: #255

Also see cloudfoundry/binary-builder#56
@arjun024 arjun024 mentioned this issue Sep 27, 2021
Merged
5 tasks
arjun024 added a commit that referenced this issue Sep 27, 2021
@arjun024
Use repackaged php dependency, use dep-server, new packit
9286552 
Fixes: #253
Fixes: #255

Also see cloudfoundry/binary-builder#56
thitch97 pushed a commit that referenced this issue Sep 28, 2021
@arjun024
Use repackaged php dependency, use dep-server, new packit (#293)
0ec6bc0 
Fixes: #253
Fixes: #255

Also see cloudfoundry/binary-builder#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use repackaged php dependency, use dep-server, new packit paketo-buildpacks/php-dist
2 participants
@arjun024 @sophiewigmore