Fix two small bugs #1001
Merged
Fix two small bugs #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First. This fixes the case where running in a paketo-community repo. It prevents the Docker credentials from being added to the test workflow multiple times. Second. This fixes an issue where you try to run `octo` outside of Github Actions, like on your local machine. In this case, `$GITHUB_REPOSITORY` probably will not be set and so the seed string for the cron jitter will be just `Update Go ` which is static and always returns the same number. This will unnecessarily change the cron value used in the `Update Go` job. This change will fallback to looking at the directory paths to try and find the right name to use. It assumes the folder structure is `paketo-buildpacks/<some-buildpack>` like the way repos are structured on Github. This will not be perfect, but it a bit better. Signed-off-by: Daniel Mikusa <dan@mikusa.com>
dmikusa
added
type:bug
pivotal-david-osullivan
approved these changes
Feb 13, 2023
This was referenced Mar 22, 2023
This was referenced Mar 22, 2023
This was referenced Mar 22, 2023
This was referenced Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First. This fixes the case where running in a paketo-community repo. It prevents the Docker credentials from being added to the test workflow multiple times.
Second. This fixes an issue where you try to run
octooutside of Github Actions, like on your local machine. In this case,$GITHUB_REPOSITORYprobably will not be set and so the seed string for the cron jitter will be justUpdate Gowhich is static and always returns the same number. This will unnecessarily change the cron value used in theUpdate Gojob. This change will fallback to looking at the directory paths to try and find the right name to use. It assumes the folder structure ispaketo-buildpacks/<some-buildpack>like the way repos are structured on Github. This will not be perfect, but it a bit better.Signed-off-by: Daniel Mikusa dan@mikusa.com