Add support for merge queues #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a merge group event type which can be added to workflows as a trigger. It exposes the documented types, of which there is only one, and it adds filters for branch and path (these are not documented, but I see references to them in other projects and they are needed to make this useful). It also updates the tests workflow so that tests are run when a merge group event is detected. It does not add label checks or action workflows. Those will run on PR, which is probably sufficient. We just want to re-run the tests in the merge queue to validate. This PR has not been tested because we cannot use the merge queue feature yet. EasyCLA is not compatible. This is an attempt to prepare but a follow up PR may be required. Consider this experimental for now. Resolves #1036 Signed-off-by: Daniel Mikusa <dan@mikusa.com>
dmikusa
added
type:enhancement
This was referenced Mar 22, 2023
This was referenced Mar 22, 2023
This was referenced Mar 22, 2023
This was referenced Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a merge group event type which can be added to workflows as a trigger. It exposes the documented types, of which there is only one, and it adds filters for branch and path (these are not documented, but I see references to them in other projects and they are needed to make this useful). It also updates the tests workflow so that tests are run when a merge group event is detected. It does not add label checks or action workflows. Those will run on PR, which is probably sufficient. We just want to re-run the tests in the merge queue to validate.
This PR has not been tested because we cannot use the merge queue feature yet. EasyCLA is not compatible. This is an attempt to prepare but a follow up PR may be required. Consider this experimental for now.
Resolves #1036