Set CGO_ENABLED=0 when we build #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This forces the Go compile tools to produce a statically linked binary. In Go 1.20, the default changed to producing a binary that is dynamically linked against libc. We could use that, but it can create compatibility issues if the build system has a newer libc version than on the stacks we support. Presently, that happens because the buildsystems are on Jammy and we have to support the Bionic stack for a bit longer. Signed-off-by: Daniel Mikusa <dan@mikusa.com>
dmikusa
added
type:bug
pivotal-david-osullivan
approved these changes
Apr 6, 2023
This was referenced Apr 10, 2023
This was referenced Apr 10, 2023
This was referenced Apr 10, 2023
This was referenced Apr 10, 2023
5 tasks
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces the Go compile tools to produce a statically linked binary. In Go 1.20, the default changed to producing a binary that is dynamically linked against libc. We could use that, but it can create compatibility issues if the build system has a newer libc version than on the stacks we support.
Presently, that happens because the buildsystems are on Jammy and we have to support the Bionic stack for a bit longer.