-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes two minor issues with the multi-arch support #1438
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Bellsoft calls the arch `arm`, but they strip off the bitness for their own reasons. We are not going to do that cause most places want arm64 not just arm. Thus, we look for arm64 and convert it to just arm for Bellsoft's api. 2. Pass the arch into the update-buildpack-dependency tool. It now uses it to select what is updated. Signed-off-by: Daniel Mikusa <dan@mikusa.com>
dmikusa
added
type:bug
A general bug
semver:patch
A change requiring a patch version bump
labels
Jan 19, 2024
5 tasks
This was referenced Jan 19, 2024
This was referenced Jan 19, 2024
This was referenced Jan 19, 2024
This was referenced Jan 19, 2024
This was referenced Jan 19, 2024
This was referenced Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
arm
, but they strip off the bitness for their own reasons. We are not going to do that cause most places want arm64 not just arm. Thus, we look for arm64 and convert it to just arm for Bellsoft's api.Use Cases
Multi-arch support.
Checklist