Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes two minor issues with the multi-arch support #1438

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Jan 19, 2024

Summary

  1. Bellsoft calls the arch arm, but they strip off the bitness for their own reasons. We are not going to do that cause most places want arm64 not just arm. Thus, we look for arm64 and convert it to just arm for Bellsoft's api.
  2. Pass the arch into the update-buildpack-dependency tool. It now uses it to select what is updated.

Use Cases

Multi-arch support.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

1. Bellsoft calls the arch `arm`, but they strip off the bitness for their own reasons. We are not going to do that cause most places want arm64 not just arm. Thus, we look for arm64 and convert it to just arm for Bellsoft's api.
2. Pass the arch into the update-buildpack-dependency tool. It now uses it to select what is updated.

Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Jan 19, 2024
@dmikusa dmikusa requested a review from a team as a code owner January 19, 2024 04:35
@dmikusa dmikusa merged commit 574133b into main Jan 19, 2024
8 checks passed
@dmikusa dmikusa deleted the arch-fixes branch January 19, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant