Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bellsoft liberica NIK retrieval #1535

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fix bellsoft liberica NIK retrieval #1535

merged 1 commit into from
Mar 25, 2024

Conversation

anthonydahanne
Copy link
Member

The NIK urls from Bellsoft have changed from:
https://download.bell-sw.com/vm/23.0.3/bellsoft-liberica-vm-core-openjdk17.0.10+13-23.0.3+1-linux-amd64.tar.gz

to

https://github.com/bell-sw/LibericaNIK/releases/download/23.0.3+1-17.0.10+13/bellsoft-liberica-vm-core-openjdk17.0.10+13-23.0.3+1-linux-amd64.tar.gz

To make it slightly more complicated, the list of Components have changed for the source URL; hence the change with componentKey

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@anthonydahanne anthonydahanne requested a review from a team as a code owner March 22, 2024 20:11
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Mar 25, 2024
@anthonydahanne
Fix bellsoft liberica NIK retrieval
fc7badb 
* there can be, i particular for sources retrieval, https://api.bell-sw.com/v1/nik/releases?package-type=src.tar.gz&version-modifier=latest&bundle-type=standard&component-version=liberica%4017, several components; let's just focus on liberica :

"components": [
      {
        "version": "23.0.3",
        "embedded": true,
        "component": "icu4j"
      },
      {
        "version": "17.0.10+13",
        "embedded": true,
        "component": "liberica"
      },
      ...
]
@dmikusa dmikusa merged commit 3ee1e65 into main Mar 25, 2024
6 checks passed
@dmikusa dmikusa deleted the fix-bellsoft branch March 25, 2024 19:13
@paketo-bot paketo-bot mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmikusa dmikusa dmikusa approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonydahanne @dmikusa