Change the way Java stackdriver version is being represented #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Google Stackdriver Java agnet is using a date based version. Previously, this action would take the date part and stuff that into the major version field, followed by the RC number as the minor version. This resulted in the buildpack bumping a major version for every release, unless it's manually corrected. This PR changes the transformation of the date to a version such that the major version won't change nearly as often. It takes the year from the date and sets that to the major version, the month to the minor version and the patch version becomes the combination of the date and the RC number. Ex: 2021.11.100. It's not perfect, but we need a version in that format and this will ensure that we're not bumping major versions every time a new release drops. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
added
type:bug
This was referenced Nov 4, 2021
This was referenced Nov 4, 2021
This was referenced Nov 4, 2021
This was referenced Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Google Stackdriver Java agent is using a date-based version. Previously, this action would take the date part and stuff that into the major version field, followed by the RC number as the minor version. This resulted in the buildpack bumping a major version for every release unless it's manually corrected.
This PR changes the transformation of the date to a version such that the major version won't change nearly as often. It takes the year from the date and sets that to the major version, the month to the minor version and the patch version becomes the combination of the date and the RC number. Ex: 2021.11.100.
It's not perfect, but we need a version in that format and this will ensure that we're not bumping major versions every time a new release drops.
Use Cases
Checklist