-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logic on package-buildpack.sh #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The previous logic would require PUBLISH=true to run `pack buildpack package` and publish the result. This was OK, but if PUBLISH was set to anything else, even an empty string, it would still run `pack buildpack package`. It doesn't seem like this was actually happening in the pipelines, but this change makes the logic stricter. You need to have PUBLISH=true exactly, or it won't publish. - Inside the publish block, we were checking if VERSION_MINOR and VERSION_MAJOR have content. This was incorrectly assuming that these variables will always be set, which was causing pipeline failures. This logic changes the behavior to account for them being not set or empty, and in both cases skips the block that would add additional tags. If there is content, then we'll set the additional tags. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
added
type:bug
A general bug
semver:patch
A change requiring a patch version bump
labels
Jan 28, 2022
This was referenced Feb 9, 2022
This was referenced Feb 9, 2022
This was referenced Feb 10, 2022
This was referenced Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pack buildpack package
and publish the result. This was OK, but if PUBLISH was set to anything else, even an empty string, it would still runpack buildpack package
. It doesn't seem like this was actually happening in the pipelines, but this change makes the logic stricter. You need to have PUBLISH=true exactly, or it won't publish.Checklist