-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert version format change #549
Conversation
Reverts version format change introduced with a0c5b6f. We can't make that change at this time as it impacts other buildpacks. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
@garethjevans - Sorry. I didn't have enough 🍵 this morning when I was reviewing your PR. We can't change this line as it will impact other buildpacks. Your original comment was spot on. As I mentioned, there are assumptions about versions looking a particular way in our pipelines. I'd love to get rid of those, but it's a larger effort so I can't do that now. I'm reverting this change back. I suspect that it'll still be OK with Tomee, but probably just not ideal. The code will strip off the milestone marker, so you'll get 10.0.5 instead of 10.0.5-M1. Not great, but if Tomee is similar to Tomcat in version numbers, there will never be both a 10.0.5 and a 10.0.5-M1 so it's still specific enough. Let me know if you're seeing some other problem caused by this though and we can chat more. |
Summary
Reverts version format change introduced with a0c5b6f.
We can't make that change at this time as it impacts other buildpacks.
Checklist