-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate CPE & PURL version #581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used same version across the version, CPE & PURL. The version was then updated to be a 3-digit version, and the system is attempting to use this 3-digit version in the CPE & PURL too (because that's the default behavior). Unfortunately, we want the full four digit version in the CPE & PURL for proper matching against vulnerabilities. This PR makes the action export the 4-digit version for the CPE & PURL and the 3-digit version for the version. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
added
type:bug
A general bug
semver:patch
A change requiring a patch version bump
labels
Mar 2, 2022
This was referenced Mar 10, 2022
This was referenced Mar 10, 2022
This was referenced Mar 11, 2022
This was referenced Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, we used same version across the version, CPE & PURL. The version was then updated to be a 3-digit version, and the system is attempting to use this 3-digit version in the CPE & PURL too (because that's the default behavior). Unfortunately, we want the full four digit version in the CPE & PURL for proper matching against vulnerabilities.
This PR makes the action export the 4-digit version for the CPE & PURL and the 3-digit version for the version.
Checklist