Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate CPE & PURL version #581

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Add separate CPE & PURL version #581

merged 1 commit into from
Mar 2, 2022

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Mar 2, 2022

Summary

Previously, we used same version across the version, CPE & PURL. The version was then updated to be a 3-digit version, and the system is attempting to use this 3-digit version in the CPE & PURL too (because that's the default behavior). Unfortunately, we want the full four digit version in the CPE & PURL for proper matching against vulnerabilities.

This PR makes the action export the 4-digit version for the CPE & PURL and the 3-digit version for the version.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Previously, we used same version across the version, CPE & PURL. The version was then updated to be a 3-digit version, and the system is attempting to use this 3-digit version in the CPE & PURL too (because that's the default behavior). Unfortunately, we want the full four digit version in the CPE & PURL for proper matching against vulnerabilities.

This PR makes the action export the 4-digit version for the CPE & PURL and the 3-digit version for the version.

Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Mar 2, 2022
@dmikusa dmikusa requested a review from a team March 2, 2022 21:20
@dmikusa dmikusa merged commit df0d615 into main Mar 2, 2022
@dmikusa dmikusa deleted the liberty-purl-cpe branch March 2, 2022 21:59
This was referenced Mar 10, 2022
This was referenced Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant