Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an action to update draft release notes #630

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Add an action to update draft release notes #630

merged 1 commit into from
Apr 14, 2022

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Apr 13, 2022

Summary

  • Adds action draft-release which replaces update-draft-release-buildpack.sh
  • Deprecates usage of update-draft-release-buildpack.sh, this will be removed in a future version
  • Action takes the same inputs, release name, release id, release body and release tag name. It also takes a dry_run argument for testing. When set to anything, it will write the name/body files to STDOUT and skip calling gh, instead writing the command that would have been called. This is for testing purposes.
  • Adds tests for all of the draft release behavior, including: sourcing information, loading remote buildpack info, and generating output from templates
  • Adds workflows to generate and publish the action
  • Modifies octo to use the action instead of the previous script. This should be a drop-in replacement, but if it breaks pipelines we retain the script so that you can switch back to it.

Use Cases

Remove shell scripts and replace with Go-based, testable actions.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa dmikusa added type:task A general task semver:patch A change requiring a patch version bump labels Apr 13, 2022
@dmikusa dmikusa requested review from a team and pivotal-david-osullivan April 13, 2022 20:15
@dmikusa dmikusa force-pushed the release-draft branch 2 times, most recently from 98e4f2c to 4286c01 Compare April 13, 2022 20:54
- Adds action `draft-release` which replaces `update-draft-release-buildpack.sh`
- Deprecates usage of `update-draft-release-buildpack.sh`, this will be removed in a future version
- Action takes the same inputs, release name, release id, release body and release tag name. It also takes a `dry_run` argument for testing. When set to anything, it will write the name/body files to STDOUT and skip calling `gh`, instead writing the command that would have been called. This is for testing purposes.
- Adds tests for all of the draft release behavior, including: sourcing information, loading remote buildpack info, and generating output from templates
- Adds workflows to generate and publish the action
- Modifies octo to use the action instead of the previous script. This should be a drop-in replacement, but if it breaks pipelines we retain the script so that you can switch back to it.

Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
@dmikusa dmikusa merged commit 062dd10 into main Apr 14, 2022
@dmikusa dmikusa deleted the release-draft branch April 14, 2022 13:39
This was referenced Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants