-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an action to update draft release notes #630
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikusa
added
type:task
A general task
semver:patch
A change requiring a patch version bump
labels
Apr 13, 2022
dmikusa
force-pushed
the
release-draft
branch
2 times, most recently
from
April 13, 2022 20:54
98e4f2c
to
4286c01
Compare
- Adds action `draft-release` which replaces `update-draft-release-buildpack.sh` - Deprecates usage of `update-draft-release-buildpack.sh`, this will be removed in a future version - Action takes the same inputs, release name, release id, release body and release tag name. It also takes a `dry_run` argument for testing. When set to anything, it will write the name/body files to STDOUT and skip calling `gh`, instead writing the command that would have been called. This is for testing purposes. - Adds tests for all of the draft release behavior, including: sourcing information, loading remote buildpack info, and generating output from templates - Adds workflows to generate and publish the action - Modifies octo to use the action instead of the previous script. This should be a drop-in replacement, but if it breaks pipelines we retain the script so that you can switch back to it. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
pivotal-david-osullivan
approved these changes
Apr 14, 2022
This was referenced Apr 19, 2022
This was referenced Apr 19, 2022
This was referenced Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
draft-release
which replacesupdate-draft-release-buildpack.sh
update-draft-release-buildpack.sh
, this will be removed in a future versiondry_run
argument for testing. When set to anything, it will write the name/body files to STDOUT and skip callinggh
, instead writing the command that would have been called. This is for testing purposes.Use Cases
Remove shell scripts and replace with Go-based, testable actions.
Checklist