-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /tmp to container #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dockerfile for the actions was not adding '/tmp', but it should. Github Actions don't create this by default so there's no temp directory. The Github runner temp directory also does not make sense becasue that's a path on the VM not in the container where the action runs. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
added
type:bug
A general bug
semver:patch
A change requiring a patch version bump
labels
Apr 14, 2022
Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
This was referenced Apr 19, 2022
This was referenced Apr 19, 2022
This was referenced Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Dockerfile for the actions was not adding '/tmp', it can't because it's a
scratch
image and there's no shell. Github Actions don't create/tmp
either so there's no temp directory.The Github runner temp directory does not help either because that's a path on the VM not in the container where the action runs.
As such, we are making
/tmp
in code and then using/tmp
specifically for tempfiles.Checklist