Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /tmp to container #640

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Add /tmp to container #640

merged 2 commits into from
Apr 14, 2022

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Apr 14, 2022

Summary

The Dockerfile for the actions was not adding '/tmp', it can't because it's a scratch image and there's no shell. Github Actions don't create /tmp either so there's no temp directory.

The Github runner temp directory does not help either because that's a path on the VM not in the container where the action runs.

As such, we are making /tmp in code and then using /tmp specifically for tempfiles.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

The Dockerfile for the actions was not adding '/tmp', but it should. Github Actions don't create this by default so there's no temp directory. The Github runner temp directory also does not make sense becasue that's a path on the VM not in the container where the action runs.

Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Apr 14, 2022
@dmikusa dmikusa requested a review from a team April 14, 2022 19:02
Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
@dmikusa dmikusa merged commit 3db08a5 into main Apr 14, 2022
@dmikusa dmikusa deleted the docker branch April 14, 2022 19:23
This was referenced Apr 19, 2022
This was referenced Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant