Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 273: Auto detect native image #359

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Fix 273: Auto detect native image #359

merged 4 commits into from
Jun 13, 2023

Conversation

anthonydahanne
Copy link
Member

@anthonydahanne anthonydahanne commented May 9, 2023 •
edited
Loading

Summary

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@anthonydahanne anthonydahanne requested a review from a team as a code owner May 9, 2023 16:22
@anthonydahanne anthonydahanne marked this pull request as draft May 9, 2023 16:23
@anthonydahanne anthonydahanne force-pushed the fix-273-detect-native branch 2 times, most recently from 21f8cce to 34375c8 Compare May 10, 2023 19:22
@anthonydahanne anthonydahanne self-assigned this May 10, 2023
@anthonydahanne anthonydahanne marked this pull request as ready for review May 10, 2023 19:23
@anthonydahanne anthonydahanne added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels May 10, 2023
@anthonydahanne anthonydahanne mentioned this pull request May 10, 2023
Closed
pivotal-david-osullivan
pivotal-david-osullivan requested changes May 25, 2023
View reviewed changes
boot/native_image.go Show resolved Hide resolved
boot/native_image_test.go Outdated Show resolved Hide resolved
@anthonydahanne
Copy link
Member Author

hello @pivotal-david-osullivan , @dmikusa !
I've added some sample tests to assert that my changes, published through a composite and a builder, did not harm existing use cases; for Spring Boot 3.0 builds, as well as Spring Boot 3.1 - please disregarde the java node builds, they can't run on tiny builder.

I invite you to check those temporary samples out and... review one last time this PR!

Thanks a lot!

pivotal-david-osullivan
pivotal-david-osullivan reviewed Jun 12, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
anthonydahanne and others added 4 commits June 13, 2023 09:05
@anthonydahanne
Fix 273: Auto detect native image
bbff132
@anthonydahanne
Close #273: Use BP_MAVEN_ACTIVE_PROFILES to detect native
1ecb10b 
* so that the user does not need to specify BP_NATIVE_IMAGE=true as well
@anthonydahanne
Close #273: clean up unneeded debug log
fc9ec81 
* checked with @pivotal-david-osullivan
@anthonydahanne @pivotal-david-osullivan
Add link to native-image
a35ecf9 
Co-authored-by: David O'Sullivan <31728678+pivotal-david-osullivan@users.noreply.github.com>
@anthonydahanne anthonydahanne mentioned this pull request Jun 13, 2023
Merged
5 tasks
@anthonydahanne anthonydahanne merged commit cb201f1 into main Jun 13, 2023
@anthonydahanne anthonydahanne deleted the fix-273-detect-native branch June 13, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pivotal-david-osullivan pivotal-david-osullivan pivotal-david-osullivan approved these changes

Assignees

@anthonydahanne anthonydahanne

Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonydahanne @pivotal-david-osullivan