Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make KeyWithAlgorithm json-serializable #23

Merged
merged 1 commit into from
Feb 24, 2016
Merged

make KeyWithAlgorithm json-serializable #23

merged 1 commit into from
Feb 24, 2016

Conversation

bavardage
Copy link
Contributor

No description provided.

markelliot added a commit that referenced this pull request Feb 24, 2016
@markelliot
Merge pull request #23 from palantir/feature/kwa-serialization
1f804d0 
make KeyWithAlgorithm json-serializable
@markelliot markelliot merged commit 1f804d0 into develop Feb 24, 2016
@markelliot markelliot deleted the feature/kwa-serialization branch February 24, 2016 23:29
@markelliot
Copy link
Contributor

@jlz27 this should fix your serialization issues

@jlzhao27
Copy link

will this be release soon? also the MP client is dumb so I could make the API nicer but I still need to do manual deserialization.

@bavardage
Copy link
Contributor Author

I'll cut a release

@jlzhao27
Copy link

great, just saw 1.5 is out, will update MP commit

@bavardage
Copy link
Contributor Author

It’ll take a little bit for bintray to pick it up, etc. Give it 20 mins or so…

From: Jason Zhao <notifications@github.commailto:notifications@github.com>
Reply-To: palantir/encrypted-config-value <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, 24 February 2016 at 16:52
To: palantir/encrypted-config-value <encrypted-config-value@noreply.github.commailto:encrypted-config-value@noreply.github.com>
Cc: Benjamin Duffield <bduffield@palantir.commailto:bduffield@palantir.com>
Subject: Re: [encrypted-config-value] make KeyWithAlgorithm json-serializable (#23)

great, just saw 1.5 is out, will update MP commit

—
Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_palantir_encrypted-2Dconfig-2Dvalue_pull_23-23issuecomment-2D188539041&d=CwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=gf9hp_WD7xvcyNuk3MQQqdaF8sJHy46JtuMQaPdX7gQ&m=bZpqnwn5SrmkbkLmP2Z66BaFAktYQfUY7drZde4kjA8&s=8YqsLvOAZOAGY9uwo1vxlnctXVNl7oFxOA0jMvJ2Lxs&e=.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bavardage @markelliot @jlzhao27