Fix poms to contain versions #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@uschi2000 do I need to do anything with bintray creds here? e.g. do I need different ones or will the current ones be good? |
j-baker
commented
Apr 24, 2018
| RSA("RSA", () -> RsaKeyPair.newKeyPair(), () -> RsaOaepEncrypter.INSTANCE); | ||
| AES("AES", AesGcmEncrypter.INSTANCE) { | ||
| @Override | ||
| public KeyPair newKeyPair() { |
There was a problem hiding this comment.
errorprone demands this?
https://github.com/google/error-prone/blob/master/docs/bugpattern/ImmutableEnumChecker.md
There was a problem hiding this comment.
ok so we were being naughty with our enums before by having them take suppliers I guess
bavardage
reviewed
Apr 24, 2018
| @@ -30,28 +29,35 @@ | |||
| * algorithm with a supported key. | |||
| */ | |||
| public enum Algorithm { | |||
| AES("AES", () -> AesKeyPair.newKeyPair(), () -> AesGcmEncrypter.INSTANCE), | |||
| RSA("RSA", () -> RsaKeyPair.newKeyPair(), () -> RsaOaepEncrypter.INSTANCE); | |||
| AES("AES", AesGcmEncrypter.INSTANCE) { | |||
bavardage
reviewed
Apr 24, 2018
|
|
||
| Algorithm(String name, Supplier<KeyPair> keyPairGenerator, Supplier<Encrypter> cipherGenerator) { | ||
| Algorithm(String name, Encrypter cipher) { |
There was a problem hiding this comment.
see above - errorprone was demanding it
|
current creds should be good |
bavardage
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does a few things, because stuff kept breaking.