Fail fast if outgoing configurations are realized early #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
fawind
reviewed
May 19, 2020
| + "This is not allowed when using GCV.", | ||
| configuration.get())); | ||
| } | ||
| return ImmutableList.of(); |
There was a problem hiding this comment.
We need to return this so the resolution constraint gets triggered in addAllLater?
There was a problem hiding this comment.
yep, I didn't know how else to add this as a "lazy effect" essentially
fawind
approved these changes
May 19, 2020
|
Released 1.18.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Hard to debug bad interactions with other plugins.
For instance, the kotlin plugin realizes the dependencies of a bunch of java configurations early (at configuration time), and GCV doesn't allow that (see #423 (comment)).
However, by the time GCV fails, it will fail like so, and the stack trace won't point to who "included this configuration in dependency resolution" in the first place.
After this PR
==COMMIT_MSG==
Immediately throw an error capturing the stacktrace when other plugins / gradle code are attempting to realize configuration dependencies/constraints early (at configuration-time) and throw an error.
==COMMIT_MSG==
Possible downsides?