This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
Loosen equality on crds. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s sets fields when we submit our CRD to the api, this causes issues when we come to compare local versions to it later. kubernetes-sigs/kubebuilder#592
rkaram
suggested changes
Oct 21, 2021
rkaram
approved these changes
Oct 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k8s sets additional fields when we submit our CRD to the api server, this causes issues when we come to compare local versions to it later. To get around this, we only compare the values that are necessary for us to determine whether or not to update.
kubernetes-sigs/kubebuilder#592