allow conditional expressions (#4606)

palantir · Mar 26, 2019 · 92d188a · 92d188a
1 parent a493460
commit 92d188a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/rules/noVoidExpressionRule.ts b/src/rules/noVoidExpressionRule.ts
@@ -104,6 +104,10 @@ function walk(ctx: Lint.WalkContext<Options>, checker: ts.TypeChecker): void {
             // Something like "x && console.log(x)".
             case ts.SyntaxKind.BinaryExpression:
                 return isParentAllowedVoid(node.parent);
+
+            // Something like "!!cond ? console.log(true) : console.log(false)"
+            case ts.SyntaxKind.ConditionalExpression:
+                return true;
             default:
                 return false;
         }

diff --git a/test/rules/no-void-expression/default/test.ts.lint b/test/rules/no-void-expression/default/test.ts.lint
@@ -24,4 +24,6 @@ declare function doIt(): void;
 declare function doAsync(): Promise<void>;
 declare function print(strs: TemplateStringsArray): void;
 
+!!data ? console.info(message, data) : console.info(message);
+
 [0]: Expression has type `void`. Put it on its own line as a statement.