Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix issue with case sensitivity of noUnusedVariable rule on Windows #2819

Merged
merged 2 commits into from
May 24, 2017

Conversation

piotrtomiak
Copy link
Contributor

@piotrtomiak piotrtomiak commented May 24, 2017

PR checklist

Overview of change:

When TSLint is being used to provide as-you-type linting as in Angular IDE, incorrect configuration of program created in makeUnusedCheckedProgram function is causing whole functionality to blow up. The core of the issue is that SourceFiles are being assigned case sensitive path when program is recreated for TSLint validation, which later causes that wrong path to stick and file not found problems appear in whole IDE.

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

[bugfix] Fix issue with case sensitivity of noUnusedVariable rule on Windows

When TSLint is being used to provide as-you-type linting as in Angular
IDE, incorrect configuration of program created in
makeUnusedCheckedProgram function is causing whole functionality to blow
up. The core of the issue is that SourceFiles are being assigned case
sensitive path when program is recreated for TSLint validation, which
later causes that wrong path to stick and file not found problems appear
in whole IDE.

Change-Id: I05bcf150393f96e28c48d3b0a9a20e96002e5446
@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @piotrtomiak! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @piotrtomiak! I added in some minor code style fixes.

@piotrtomiak
Copy link
Contributor Author

Awesome, thanks for quick turnaround!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants