Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Remove some difficult recommended rules #4312

Merged
merged 2 commits into from
Oct 5, 2019
Merged

Remove some difficult recommended rules #4312

merged 2 commits into from
Oct 5, 2019

Conversation

aghoneim92
Copy link
Contributor

PR checklist

Overview of change:

Removed the following four rules from the recommended toolset:

  1. interface-name
  2. member-access
  3. object-literal-sort-keys
  4. ordered-imports

Is there anything you'd like reviewers to focus on?

Should we remove even more rules? I personally don't like member-ordering either.

CHANGELOG.md entry:

[enhancement] remove pedantic rules from the recommended config

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @aghoneim92! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 22, 2018
View reviewed changes
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aghoneim92!

This PR will have to wait until TSLint is ready to start merging in breaking changes ☹ but otherwise looks good.

@VincentLanglet VincentLanglet mentioned this pull request Dec 28, 2018
Closed
@JoshuaKGoldberg
Copy link
Contributor

JoshuaKGoldberg commented Oct 2, 2019 •
edited
Loading

This is ready to go in! @aghoneim92, would you mind resolving merge conflicts? If not I can send a separate PR. I just went ahead and did that - they were tiny.

@JoshuaKGoldberg
Copy link
Contributor

#4871 is a superset of this.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 5, 2019
View reviewed changes
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🙌

@JoshuaKGoldberg JoshuaKGoldberg merged commit 88fbdf2 into palantir:master Oct 5, 2019
@adidahiya
Copy link
Contributor

personally, I like member-access and ordered-imports. especially the latter since it has a nice auto-fixer. I would like to bring these back in a new tslint:strict ruleset

@adidahiya adidahiya mentioned this pull request Nov 3, 2019
Merged
mgechev pushed a commit to angular/angular-cli that referenced this pull request Mar 17, 2020
@alan-agius4 @mgechev
feat(@schematics/angular): update default tslint.json rules
df4382f 
In tslint version 6, several recommanded rules have been removed in the following PRs:
palantir/tslint#4871 palantir/tslint#4312

With this change, we bring back these rules in the CLI.
mgechev pushed a commit to angular/angular-cli that referenced this pull request Mar 17, 2020
@alan-agius4 @mgechev
feat(@schematics/angular): add migration to update tslint to version 6
a144e82 
In tslint version 6, several recommanded rules have been removed in the following PRs:
palantir/tslint#4871 palantir/tslint#4312

With this migration we update the tslint depedency to 6+ and add back these rules in the user workspace `tslint.json` also we remove some deprecated rules.

Until version 10, this is an opt-in migration and users will need to run this manually with the below command:
```
ng update @angular/cli --migrate-only tslint-version-6
```

Closes: #17117
Reference: TOOL-1348
@snebjorn snebjorn mentioned this pull request Mar 25, 2020
Closed
This was referenced Mar 14, 2021
Merged
Closed
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aghoneim92 @palantirtech @JoshuaKGoldberg @adidahiya