-
Notifications
You must be signed in to change notification settings - Fork 887
Added support for 'ignore-rest-args' option in 'no-any' rule #4581
Added support for 'ignore-rest-args' option in 'no-any' rule #4581
Conversation
Thanks for your interest in palantir/tslint, @vmk1vmk! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
6529de4
to
d91e52b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to contributing @vmk1vmk! ✨
Sorry for the delay - this mostly looks good, just a couple of touchups.
… code example and documentation.
…pe from array to object.
74c3ef3
to
88d5bfb
Compare
👋 just a heads up @vmk1vmk, you don't need to force push. We squash commits on PRs anyway, and it's actually more useful to us as reviewers to see the commits as originally created. |
@JoshuaKGoldberg Sorry I didn't know that, and thanks for putting the effort into the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks @vmk1vmk! 🚀
PR checklist
Overview of change:
ignore-rest-args
tono-any
lint rule.ignore-rest-args
functionality.CHANGELOG.md entry:
[new-rule-option] Added
ignore-rest-args
option tono-any