Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix typo in rule docs generation #4638

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Fix typo in rule docs generation #4638

merged 1 commit into from
Apr 4, 2019

Conversation

komputerwiz
Copy link
Contributor

PR checklist

Overview of change:

An incorrect rule type selector in rules documentation page (docs/rules/index.md) was omitting the following rules:

  • align
  • arrow-parens
  • eofline
  • import-spacing
  • indent
  • jsdoc-format
  • linebreak-style
  • max-line-length
  • newline-before-return
  • new-parens
  • no-consecutive-blank-lines
  • no-irregular-whitespace
  • no-trailing-whitespace
  • number-literal-format
  • quotemark
  • semicolon
  • trailing-comma
  • typedef-whitespace
  • whitespace

Incorrect rule type selector in rules documentation page was omitting the following rules:

* `align`
* `arrow-parens`
* `eofline`
* `import-spacing`
* `indent`
* `jsdoc-format`
* `linebreak-style`
* `max-line-length`
* `newline-before-return`
* `new-parens`
* `no-consecutive-blank-lines`
* `no-irregular-whitespace`
* `no-trailing-whitespace`
* `number-literal-format`
* `quotemark`
* `semicolon`
* `trailing-comma`
* `typedef-whitespace`
* `whitespace`
@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @komputerwiz! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@komputerwiz
Copy link
Contributor Author

Really? I have to sign a legal document in order for me to suggest adding 4 characters to a single file? 🙄

Good thing it was a short read.

@adidahiya adidahiya merged commit 5432570 into palantir:master Apr 4, 2019
@Tschrock
Copy link

Looking at the current website, it doesn't seem to have updated with this fix yet. Is there something else that needs to happen before it goes live?

@komputerwiz
Copy link
Contributor Author

Looks like the changes need to be copied to the gh-pages branch (git filter-branch, maybe?)

Anyway, further conversation should probably be on #4620 (which needs to be reopened). I'll bump the thread and link your message there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rules Documentation cut off after Format heading
4 participants