Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

[enhancement] Update devDependency nyc from v13.3.0 to v14.1.1 #4699

Merged
merged 1 commit into from
May 16, 2019
Merged

[enhancement] Update devDependency nyc from v13.3.0 to v14.1.1 #4699

merged 1 commit into from
May 16, 2019

Conversation

bjornstar
Copy link
Contributor

@bjornstar bjornstar commented May 10, 2019 •
edited
Loading

PR checklist

  • New feature, bugfix, or enhancement

Overview of change:

There is a vulnerability in handlebars for v13 of nyc, update to the latest version to avoid it.

Is there anything you'd like reviewers to focus on?

New coverage summary:

Statements   : 46.31% ( 5007/10812 )
Branches     : 39.94% ( 2664/6670 )
Functions    : 45.46% ( 881/1938 )
Lines        : 46.22% ( 4445/9617 )

Current coverage summary:

Statements   : 37.08% ( 4245/11449 )
Branches     : 24.12% ( 1646/6823 )
Functions    : 33.96% ( 868/2556 )
Lines        : 36.78% ( 3756/10212 )

CHANGELOG.md entry:

[enhancement] Update devDependency nyc from v13.3.0 to v14.1.1

@bjornstar
Copy link
Contributor Author

Raised an issue over at nyc -- istanbuljs/nyc#1111

@bjornstar bjornstar force-pushed the update-nyc-again branch 3 times, most recently from 58d775d to ba92395 Compare May 10, 2019 23:29
@bjornstar
Copy link
Contributor Author

The istanbul team was very helpful and now we have improved coverage, this is ready to go.

@adidahiya
Copy link
Contributor

Try merging master now that #4731 is in to fix the testNext build

@bjornstar
Copy link
Contributor Author

Try merging master now that #4731 is in to fix the testNext build

The test is passing now.

adidahiya
adidahiya approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks @bjornstar

@adidahiya adidahiya merged commit 94dafa0 into palantir:master May 16, 2019
@adidahiya adidahiya mentioned this pull request May 30, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 11, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 15, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 19, 2020
Merged
This was referenced Mar 18, 2020
Closed
Open
Open
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 31, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@bjornstar bjornstar deleted the update-nyc-again branch April 12, 2021 04:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjornstar @adidahiya