Enhance the fixer of interface-over-type-literal

[ychen10]

PR checklist

• Addresses an existing issue: fixes Have interface-over-type-literal replace trailing comma delimiters with semicolons #4795
• New feature, bugfix, or enhancement
  • Includes tests
• Documentation update

Overview of change:

Added a step in the fixer so that it goes into the members to check if they carry a trailing comma. If they do, replace it with semicolon. The fixed interface now looks like

interface User {
  someData: {
    firstName: string,
    lastName: string,
    registered: boolean,
  };
  location: string;
  quantity: number;
}

instead of

interface User {
  someData: {
    firstName: string,
    lastName: string,
    registered: boolean,
  },
  location: string,
  quantity: number,
}

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

[enhancement] interface-over-type-literal The fixer now makes sure that the interface uses semicolon to separate individual member declarations.

[palantirtech]

Thanks for your interest in palantir/tslint, @ychen10! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[ychen10]

Test failing as per #4784

[JoshuaKGoldberg]

Declined per #4795 😢.

In general, until an issue is marked as Status: Accepting PRs, it's better to hold off on writing a PR. You never know when an issue will be declined by some annoying maintainer.

[JoshuaKGoldberg]

If you fork this rule and use it in your own project, you might want to write some test cases around comments and spacing:

type Wat = {
    someMember : string /* gotcha! */,
}

[ychen10]

Got it. Thanks!

[JoshuaKGoldberg]

FWIW, you can always fork this rule (copy & paste the .js output into a new file) and use it in your own project instead of the core rule.