This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
[max-line-length] ignore strings and regex in max line length #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or template strings.
…ng checks enabled.
…ts with older versions.
vmk1vmk
changed the title
|
Failing in |
…used consistently.
JoshuaKGoldberg
suggested changes
Jul 16, 2019
… combined the two consecutive filter calls into one.
|
@JoshuaKGoldberg Thanks for reviewing so fast. I made all requested changes. |
No, this looks fine. TSLint's being deprecated soon (#4534) and has been recommending using Prettier instead of formatting rules for quite some time. I don't think that extra logic will be worth the added complexity.
Looks good! 😄 I played around with this locally a bit and it worked great. |
JoshuaKGoldberg
approved these changes
Jul 16, 2019
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 1, 2019
In tslint 5.19.0 they added a separate option that determines whether strings should be checked and it seems to have been defaulted to `false` (palantir/tslint#4798). As a result we ended up with a few places where the limit was being violated. These changes explicitly enable checking of strings and fix the failures that we had accumulated.
jelbourn
pushed a commit
to angular/components
that referenced
this pull request
Nov 1, 2019
In tslint 5.19.0 they added a separate option that determines whether strings should be checked and it seems to have been defaulted to `false` (palantir/tslint#4798). As a result we ended up with a few places where the limit was being violated. These changes explicitly enable checking of strings and fix the failures that we had accumulated.
This was referenced Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Added functionality to ignore strings exceeding the max line length, it is by default enabled.
Added option
check-stringsto control if exceeding strings are skipped or treated as errors.Added the same option for regex called
check-regex.Is there anything you'd like reviewers to focus on?
check-plain-stringsandcheck-template-strings?CHANGELOG.md entry:
[enhancement] Added
check-stringsandcheck-regexoptions tomax-line-lenghtrule.