Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

fix: add option to enforce alphabetical ordering regardless of blank lines #4808

Merged
merged 2 commits into from
Jul 25, 2019
Merged

fix: add option to enforce alphabetical ordering regardless of blank lines #4808

merged 2 commits into from
Jul 25, 2019

Conversation

vedadeepta
Copy link
Contributor

@vedadeepta vedadeepta commented Jul 24, 2019 •
edited by adidahiya
Loading

PR checklist

Overview of change:

Added a option allow-blank-lines to rule object-literal-sort-keys which enforces alphabetical ordering regardless of blank lines between key/value pairs.

Is there anything you'd like reviewers to focus on?

Not sure if the option name allow-blank-lines is correct.

CHANGELOG.md entry:

[new-rule-option] ignore-blank-lines option for object-literal-sort-keys rule

@vedadeepta vedadeepta changed the title fix: add option to enfore alphabetical ordering regarding of blank lines fix: add option to enfore alphabetical ordering regardless of blank lines Jul 24, 2019
@vedadeepta vedadeepta changed the title fix: add option to enfore alphabetical ordering regardless of blank lines fix: add option to enforce alphabetical ordering regardless of blank lines Jul 24, 2019
adidahiya
adidahiya suggested changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but let's call the option "ignore-blank-lines"

@adidahiya adidahiya merged commit 9924e7a into palantir:master Jul 25, 2019
@adidahiya adidahiya mentioned this pull request Aug 20, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 11, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 15, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 19, 2020
Merged
This was referenced Mar 18, 2020
Closed
Open
Open
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 31, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
@PropTekCTO PropTekCTO mentioned this pull request May 31, 2024
Open
@christian-thiel-webcom christian-thiel-webcom mentioned this pull request Aug 10, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option for object-literal-sort-keys to not ignore blank lines
2 participants
@vedadeepta @adidahiya