-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add webhook helpers #4
base: master
Are you sure you want to change the base?
Conversation
e5897a8
to
ba64a78
Compare
ba64a78
to
e2c8854
Compare
@@ -0,0 +1,7 @@ | |||
package config | |||
|
|||
type HookType string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain the concept of the hook types, why there is only 1 external.
URL string `json:"url"` | ||
InsecureSkipVerify bool `json:"insecureSkipVerify"` | ||
TLSRootCAFile string `json:"tlsRootCAFile"` | ||
ClientAuthentication *ClientAuthentication `json:"clientAuthentication"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does the web hook behaves if there is client authentication + insecure skip verify.
@@ -0,0 +1,23 @@ | |||
package config | |||
|
|||
type ClaimsMutatingHook struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the ClaimsMutatingHook
Config *WebhookConfig | ||
} | ||
|
||
type ClaimsValidatingHook struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the ClaimsValidatingHook
@@ -0,0 +1,24 @@ | |||
package config | |||
|
|||
// HookRequestScope is the context of the request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain here what it means, of what request?
Overview
What this PR does / why we need it
Special notes for your reviewer
Does this PR introduce a user-facing change?