Skip context memoization when passing explicit context #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inkstak
force-pushed
the
feature-avoid_memoization_with_explicit_context
branch
3 times, most recently
from
ab8ac45 to
6263ca9
Compare
inkstak
commented
May 31, 2024
| record_key = record._policy_cache_key(use_object_id: true) | ||
| context_key = context.values.map { _1._policy_cache_key(use_object_id: true) }.join(".") | ||
| context_key = context_for_policy(context).values.map { _1._policy_cache_key(use_object_id: true) }.join(".") |
There was a problem hiding this comment.
Explicit context was not merged with implicit context to compute cache key.
inkstak
force-pushed
the
feature-avoid_memoization_with_explicit_context
branch
from
6263ca9 to
4f295f6
Compare
inkstak
commented
May 31, 2024
| authorization_context.merge(context).tap do | ||
| remove_instance_variable :@_authorization_context | ||
| end | ||
| end |
There was a problem hiding this comment.
It seems a bit complicated but it allows to fulfil all the following conditions:
- Keep memoization by default
- Skip memoization when passing an explicit context
- Allow someone to override
authorization_context - Use any overrided
authorization_contextas the implicit context to merge with in the explicit one.
(See #217 (comment) & #265 (comment))
|
Thanks for the PR! I decided to go in a bit different direction (to minimize changes). Now available in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #265 - 2nd suggestion :
Skip memoization when an explicit context is passed.
PR checklist:
Documentation updatedNot required since it's all about internal memoization