-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension for redis cluster mode #173
Conversation
Hi, I'll leave this PR open for now and if there is more demand I might merge it. |
@sh4nks : I support merging this PR. I just created my own backend for cluster mode to use at my company with Elasticache. I was considering submitting a similar PR. However, I understand that supporting lots of backends can increase maintenance and testing complexity. In that case, would you prefer that each additional backend be a separate package with more of a plugin/extension architecture emphasis |
Adding more backends is fun and all, but most authors who do so will abandon their addition as long as it’s merged and the maintainers will have to, well, maintain it. Since this package already supports using external backend classes, i’d probably go on the plugin/separate package way. It’s the best for everyone. About this PR, it’s not really a new backend, but the extension of an existing one. I’m with it, too. Maybe it could be incorporated into the plain redis backend? |
I am thinking about having a section with 'user contributed' backends where we do not offer 'official' support and a section with core backends that are supported by us might be sufficient. Especially if the clients/backends are getting more complex like the RedisSentinel one where testing the client took some more time since I had to setup the redis sentinels. This one looks kinda simple so I guess we can include it :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some documentation about the CACHE_REDIS_CLUSTER setting here: https://github.com/sh4nks/flask-caching/blob/master/docs/index.rst#configuring-flask-caching
and about the rediscluster
cache after the redissentinel
cache here:
https://github.com/sh4nks/flask-caching/blob/master/docs/index.rst#redissentinelcache
@AIweimd if you could add this I'd merge the PR.
|
Extension for redis cluster mode
Extension for redis cluster mode
The update document is complete. |
Add redis cluster documention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AIweimd
Thanks for adding the documentation but unfortunately you deleted some existing documentation in your latest commit. Please restore it again :-)
Add the documentation of Redis cluster mode.
import redis-py-cluster==2.0.0
CACHE_TYPE=rediscluster
Add cluster parameter of string type:
e.g. host1:port1,host2:port2,host3:port3