Skip to content

Commit

Permalink
fix py36-lowest test
Browse files Browse the repository at this point in the history
This only showed up after rebasing onto current maintenance branch.
  • Loading branch information
rsyring committed Mar 14, 2019
1 parent 7c69ea1 commit 8dacd50
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion tests/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from sqlalchemy.pool import NullPool

import flask_sqlalchemy as fsa
from flask_sqlalchemy import _compat, utils


class TestConfigKeys:
Expand Down Expand Up @@ -71,7 +72,14 @@ def test_engine_creation_ok(self, app, recwarn):
errors or warnings.
"""
assert fsa.SQLAlchemy(app).get_engine()
assert len(recwarn) == 0
if utils.sqlalchemy_version('==', '0.8.0') and not _compat.PY2:
# In CI, we test Python 3.6 and SA 0.8.0, which produces a warning for
# inspect.getargspec()
expected_warnings = 1
else:
expected_warnings = 0

assert len(recwarn) == expected_warnings


@pytest.fixture
Expand Down

0 comments on commit 8dacd50

Please sign in to comment.