Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore SQLALCHEMY_POOL_SIZE when using NullPool #426

Closed
jboegeholz opened this issue Sep 6, 2016 · 2 comments
Closed

Ignore SQLALCHEMY_POOL_SIZE when using NullPool #426

jboegeholz opened this issue Sep 6, 2016 · 2 comments
Labels
Milestone

Comments

@jboegeholz
Copy link

When using sqlite as DB and SQLALCHEMY_POOL_SIZE is set to 0 sqlalchemy throws
TypeError: Invalid argument(s) 'pool_size' sent to create_engine(), using configuration SQLiteDialect_pysqlite/NullPool/Engine

It would be great if the config param SQLALCHEMY_POOL_SIZE will be ignored in case of NullPool and a warning is issued by flask-sqlalchemy

@keiranmraine
Copy link

This is very problematic if you have tools configured to ensure all appropriate environment variables are set and provided. The hard fail results in non-generic paths having to be introduced to handle running tests with SQLite.

@rsyring rsyring added the config label Mar 8, 2019
@rsyring rsyring added this to the 2.4 milestone Mar 8, 2019
rsyring added a commit that referenced this issue Mar 9, 2019
@rsyring
Copy link
Contributor

rsyring commented Mar 9, 2019

I've added some configuration tests in #684 to confirm FSA is doing "the right thing" and, as best I can tell, it is.

FSA does not set SQLALCHEMY_POOL_SIZE on it's own. If a developer has set SQLALCHEMY_POOL_SIZE to zero explicitly, and is also using SQLite, then FSA is going to pass that through to SA no questions asked. It's up to the developer, not FSA, to make sure that combination is not occurring.

You are welcome to post back if you think I'm missing something. But I'm going to close this issue since I don't think we would make the change requested.

@rsyring rsyring closed this as completed Mar 9, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

3 participants