Allow for arbitrary Pool configuration #525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was looking for more flexibility around pools and this hook should allow for users to pass whatever pool object they want to use.
mistercrunch
changed the title
|
Is this a duplicate / related to #333? |
|
This PR here may be more flexible as you can instantiate whatever pool object you want with whatever parameter. |
|
@davidism can we get this through? I think this PR is the most flexible as it allows users to pass whatever pool configuration they may want |
|
Thank you for your contribution and sorry this took so long. I believe #684 will solve this use case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking for more flexibility around pools and this hook should
allow for users to pass whatever pool object they want to use.