Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default intermediate hash from SHA-1 to SHA-512 #80

Merged
merged 1 commit into from
Mar 16, 2017
Merged

change default intermediate hash from SHA-1 to SHA-512 #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions itsdangerous.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,12 @@ def get_signature(self, key, value):
class HMACAlgorithm(SigningAlgorithm):
"""This class provides signature generation using HMACs."""

#: The digest method to use with the MAC algorithm. This defaults to sha1
#: but can be changed for any other function in the hashlib module.
default_digest_method = staticmethod(hashlib.sha1)
#: The digest method to use with the MAC algorithm. This defaults to
#: SHA-512, but can be changed to any other function in the hashlib module.
#:
#: .. versionchanged:: 1.0
#: The default was changed from SHA-1 to SHA-512.
default_digest_method = staticmethod(hashlib.sha512)

def __init__(self, digest_method=None):
if digest_method is None:
Expand Down Expand Up @@ -295,11 +298,14 @@ class constructor.
`algorithm` was added as an argument to the class constructor.
"""

#: The digest method to use for the signer. This defaults to sha1 but can
#: be changed for any other function in the hashlib module.
#: The digest method to use for the signer. This defaults to SHA-512 but
#: can be changed to any other function in the hashlib module.
#:
#: .. versionchanged:: 1.0
#: The default was changed from SHA-1 to SHA-512.
#:
#: .. versionchanged:: 0.14
default_digest_method = staticmethod(hashlib.sha1)
#: .. versionadded:: 0.14
default_digest_method = staticmethod(hashlib.sha512)

#: Controls how the key is derived. The default is Django style
#: concatenation. Possible values are ``concat``, ``django-concat``
Expand Down Expand Up @@ -680,7 +686,7 @@ class JSONWebSignatureSerializer(Serializer):
}

#: The default algorithm to use for signature generation
default_algorithm = 'HS256'
default_algorithm = 'HS512'

default_serializer = _CompactJSON

Expand Down