Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup and escape should be imported from markupsafe #1391

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

davidism
Copy link
Member

These were still left over from Jinja's early days. Noticed they were still exported and documented, so now the Jinja versions show deprecation warnings pointing to markupsafe.

@davidism davidism added this to the 3.0.0 milestone Apr 10, 2021
@davidism davidism merged commit a9b06f4 into master Apr 10, 2021
@davidism davidism deleted the markupsafe-imports branch April 10, 2021 17:24
@CarliJoy
Copy link

I used this in paragraphs in #1386 to describe how and when to use env.get_markup_class

Also I used it to refer to the Markup class as link.
The external link didn't work.
So I kindly ask if you could fix the merge conflict #1386 cause I am kind out of ideas considering this change...

@CarliJoy CarliJoy mentioned this pull request Apr 11, 2021
11 tasks
@CarliJoy
Copy link

The problem is also that now the explaination of what Markup does and what the .__html__ means is out of the documentation.
And I kind of referred to it in other parts of the Jinja documentation. Now it is all a bit loose an and unconnected :-/

The supposed links to Markup (i.e. in the current explanation of the parameter does not work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants