fix default for Environment.overlay(enable_async)
#2061
Merged
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a test case that happens to reproduce the issue that this fixes? |
|
Very simple : from jinja2 import Environment
env = Environment(enable_async=True)
assert env.is_async == env.overlay().is_async, "overlay async state differs with parent" |
|
@SamyCookie I appreciate that you've submitted a fix, but please follow our contributing guide next time. You didn't open an issue, or explain the PR what the issue was and what the fix does. Your PR doesn't contain a test. While brevity is appreciated, you need to provide some detail rather than just dumping something on us and saying "it's obvious". |
davidism
changed the title
Environment.overlay(enable_async)
|
Rebased to target bug fix at stable instead of main. Added test. Added changelog. |
SamyCookie
commented
Dec 20, 2024
| assert not env.is_async | ||
| assert not env.overlay().is_async | ||
| env_async = env.overlay(enable_async=True) | ||
| assert env_async.is_async |
There was a problem hiding this comment.
Missing test case of the concerning issue with overlay without any enable_async parameter , that is :
assert env_async.overlay().is_async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a wrong behaviour with
Environment.overlayand seems to me an obvious error code.