BREAKING CHANGE: Dark mode support #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip * font colors * BREAKING CHANGE: background, border, font specific colors BREAKING CHANGE: background, border, font specific colors BREAKING CHANGE: Spinner variant prop changed to color * BREAKING CHANGE: ThemeProvider * feat(RadioGroup): dark mode support * feat(Accordion): dark mode support * feat(Tabs): dark mode support * feat(TabsSlider): dark mode support * dark mode tokens * Update FileUpload.tsx * Update Heading.Playground.stories.tsx * Update MediaModal.tsx * feat(Card): dark mode support * feat(Alert): dark mode support * feat(TabsSlider): dark mode support * feat(CategoryFilter): dark mode support * wip * checkboxinput * OptionTile * update pdt package with new tokens * fix build * fix lint * Update Box.tsx * checkboxinput * Update MediaModal.tsx * Update SelectInputNative.module.scss * Update Checkbox.module.scss * Update pull-request.yml * light mode button background tokens * light mode button font color tokens * light mode button border color tokens * pdt 1.3.0 * SelectInput dark mode fixes * Badge dark mode * spec body font * wip * remove internal form color tokens * remove form theming docs * wip * Toast dark mode * Toggle dark mode * Table dark mode * remove component design token documentation * more cleanup * datepicker dark mode * pdt 1.4 * Update Theming.stories.mdx
* feat: Modal dark mode * Update Modal.module.scss * Update Modal.module.scss
* fix: bump pdt * fix build
* fix(Table): dark mode loading state * Update Table.module.scss
* BREAKING CHANGE: Dark mode support (#893) * wip * font colors * BREAKING CHANGE: background, border, font specific colors BREAKING CHANGE: background, border, font specific colors BREAKING CHANGE: Spinner variant prop changed to color * BREAKING CHANGE: ThemeProvider * feat(RadioGroup): dark mode support * feat(Accordion): dark mode support * feat(Tabs): dark mode support * feat(TabsSlider): dark mode support * dark mode tokens * Update FileUpload.tsx * Update Heading.Playground.stories.tsx * Update MediaModal.tsx * feat(Card): dark mode support * feat(Alert): dark mode support * feat(TabsSlider): dark mode support * feat(CategoryFilter): dark mode support * wip * checkboxinput * OptionTile * update pdt package with new tokens * fix build * fix lint * Update Box.tsx * checkboxinput * Update MediaModal.tsx * Update SelectInputNative.module.scss * Update Checkbox.module.scss * Update pull-request.yml * light mode button background tokens * light mode button font color tokens * light mode button border color tokens * pdt 1.3.0 * SelectInput dark mode fixes * Badge dark mode * spec body font * wip * remove internal form color tokens * remove form theming docs * wip * Toast dark mode * Toggle dark mode * Table dark mode * remove component design token documentation * more cleanup * datepicker dark mode * pdt 1.4 * Update Theming.stories.mdx * feat: Modal dark mode (#894) * feat: Modal dark mode * Update Modal.module.scss * Update Modal.module.scss * fix: bump pdt (#895) * fix: bump pdt * fix build * fix(Popover): arrowColor background color type * fix: transparent border color * fix(Table): dark mode loading state (#896) * fix(Table): dark mode loading state * Update Table.module.scss * build(deps): bump ws from 6.2.2 to 6.2.3 (#897) Bumps [ws](https://github.com/websockets/ws) from 6.2.2 to 6.2.3. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.2...6.2.3) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: update color documentation * Merge branch 'main' into beta * clean up * Update Popover.VisualTests.stories.tsx * feat: document brand colors, semantic colors, and dark values * Update GetStarted.stories.mdx * fix: Alert close button color * feat: CategoryFilter dark mode tokens * docs: apply darkmode background to story canvas --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* BREAKING CHANGE: Dark mode support (#893) * wip * font colors * BREAKING CHANGE: background, border, font specific colors BREAKING CHANGE: background, border, font specific colors BREAKING CHANGE: Spinner variant prop changed to color * BREAKING CHANGE: ThemeProvider * feat(RadioGroup): dark mode support * feat(Accordion): dark mode support * feat(Tabs): dark mode support * feat(TabsSlider): dark mode support * dark mode tokens * Update FileUpload.tsx * Update Heading.Playground.stories.tsx * Update MediaModal.tsx * feat(Card): dark mode support * feat(Alert): dark mode support * feat(TabsSlider): dark mode support * feat(CategoryFilter): dark mode support * wip * checkboxinput * OptionTile * update pdt package with new tokens * fix build * fix lint * Update Box.tsx * checkboxinput * Update MediaModal.tsx * Update SelectInputNative.module.scss * Update Checkbox.module.scss * Update pull-request.yml * light mode button background tokens * light mode button font color tokens * light mode button border color tokens * pdt 1.3.0 * SelectInput dark mode fixes * Badge dark mode * spec body font * wip * remove internal form color tokens * remove form theming docs * wip * Toast dark mode * Toggle dark mode * Table dark mode * remove component design token documentation * more cleanup * datepicker dark mode * pdt 1.4 * Update Theming.stories.mdx * feat: Modal dark mode (#894) * feat: Modal dark mode * Update Modal.module.scss * Update Modal.module.scss * fix: bump pdt (#895) * fix: bump pdt * fix build * fix(Popover): arrowColor background color type * fix: transparent border color * fix(Table): dark mode loading state (#896) * fix(Table): dark mode loading state * Update Table.module.scss * build(deps): bump ws from 6.2.2 to 6.2.3 (#897) Bumps [ws](https://github.com/websockets/ws) from 6.2.2 to 6.2.3. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.2...6.2.3) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: update color documentation * Merge branch 'main' into beta * clean up * Update Popover.VisualTests.stories.tsx * feat: document brand colors, semantic colors, and dark values * Update GetStarted.stories.mdx * fix: Alert close button color * feat: CategoryFilter dark mode tokens * docs: apply darkmode background to story canvas * fix(TextInputInset): prefix and suffix dark mode colors * fix: cleanup stories * feat(Toggle): use toggle specific background color tokens * refactor(OptionTile): hover border colors * build(deps): bump palmetto-design-tokens from 1.7.1 to 1.7.2 * fix(OptionTile): selected error text color * fix: remove fullstory --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 198f5a4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 98.1% (95% is the threshold). This pull request will bring the total coverage in the repository to 97.9%. View more on Code Climate. |
palmettogithub
pushed a commit
that referenced
this pull request
Jul 17, 2024
# [2.0.0](v1.0.1...v2.0.0) (2024-07-17) * BREAKING CHANGE: Dark mode support (#902) ([1eb5499](1eb5499)), closes [#902](#902) [#894](#894) [#895](#895) [#896](#896) [#899](#899) [#894](#894) [#895](#895) [#896](#896) [#897](#897) ### BREAKING CHANGES * Dark mode support * wip * font colors * background, border, font specific colors * background, border, font specific colors * Spinner variant prop changed to color * ThemeProvider * feat(RadioGroup): dark mode support * feat(Accordion): dark mode support * feat(Tabs): dark mode support * feat(TabsSlider): dark mode support * dark mode tokens * Update FileUpload.tsx * Update Heading.Playground.stories.tsx * Update MediaModal.tsx * feat(Card): dark mode support * feat(Alert): dark mode support * feat(TabsSlider): dark mode support * feat(CategoryFilter): dark mode support * wip * checkboxinput * OptionTile * update pdt package with new tokens * fix build * fix lint * Update Box.tsx * checkboxinput * Update MediaModal.tsx * Update SelectInputNative.module.scss * Update Checkbox.module.scss * Update pull-request.yml * light mode button background tokens * light mode button font color tokens * light mode button border color tokens * pdt 1.3.0 * SelectInput dark mode fixes * Badge dark mode * spec body font * wip * remove internal form color tokens * remove form theming docs * wip * Toast dark mode * Toggle dark mode * Table dark mode * remove component design token documentation * more cleanup * datepicker dark mode * pdt 1.4 * Update Theming.stories.mdx * Dark mode support (#893) * wip * font colors * background, border, font specific colors * background, border, font specific colors * Spinner variant prop changed to color * ThemeProvider * feat(RadioGroup): dark mode support * feat(Accordion): dark mode support * feat(Tabs): dark mode support * feat(TabsSlider): dark mode support * dark mode tokens * Update FileUpload.tsx * Update Heading.Playground.stories.tsx * Update MediaModal.tsx * feat(Card): dark mode support * feat(Alert): dark mode support * feat(TabsSlider): dark mode support * feat(CategoryFilter): dark mode support * wip * checkboxinput * OptionTile * update pdt package with new tokens * fix build * fix lint * Update Box.tsx * checkboxinput * Update MediaModal.tsx * Update SelectInputNative.module.scss * Update Checkbox.module.scss * Update pull-request.yml * light mode button background tokens * light mode button font color tokens * light mode button border color tokens * pdt 1.3.0 * SelectInput dark mode fixes * Badge dark mode * spec body font * wip * remove internal form color tokens * remove form theming docs * wip * Toast dark mode * Toggle dark mode * Table dark mode * remove component design token documentation * more cleanup * datepicker dark mode * pdt 1.4 * Update Theming.stories.mdx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Adds support for dark mode, and introduces semantic tokens for things like font color, background and border, for example
So when a dark/light them is applied, the appropriate text color, background and border color will be applied.