Skip to content

Commit

Permalink
[SPARK-46531][BUILD] Move the dependency management of `datasketches-…
Browse files Browse the repository at this point in the history
…java` from `catalyst` to `parent`

### What changes were proposed in this pull request?
This pr move  the dependency management of `datasketches-java` from `catalyst/pom.xml` to `parent/pom.xml` and defined a new property xx to manage it's version.

### Why are the changes needed?
he management of dependencies with non-special versions should be placed in `parent.xml`.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass GitHub Actions

### Was this patch authored or co-authored using generative AI tooling?
No

Closes apache#44521 from LuciferYang/SPARK-46531.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
  • Loading branch information
LuciferYang authored and dongjoon-hyun committed Dec 30, 2023
1 parent 04b5128 commit af3a225
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
7 changes: 7 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@
<commons-cli.version>1.6.0</commons-cli.version>
<bouncycastle.version>1.77</bouncycastle.version>
<tink.version>1.9.0</tink.version>
<datasketches.version>3.3.0</datasketches.version>
<netty.version>4.1.100.Final</netty.version>
<netty-tcnative.version>2.0.61.Final</netty-tcnative.version>
<!--
Expand Down Expand Up @@ -2837,6 +2838,12 @@
<artifactId>arpack</artifactId>
<version>${netlib.ludovic.dev.version}</version>
</dependency>
<!-- SPARK-16484 add `datasketches-java` for support Datasketches HllSketch -->
<dependency>
<groupId>org.apache.datasketches</groupId>
<artifactId>datasketches-java</artifactId>
<version>${datasketches.version}</version>
</dependency>
</dependencies>
</dependencyManagement>

Expand Down
1 change: 0 additions & 1 deletion sql/catalyst/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@
<dependency>
<groupId>org.apache.datasketches</groupId>
<artifactId>datasketches-java</artifactId>
<version>3.3.0</version>
</dependency>
</dependencies>
<build>
Expand Down

0 comments on commit af3a225

Please sign in to comment.