Complete signature of value_counts

[refack]

For Index, Series, DataFrame

• Closes Changed SeriesGroupBy to return Series #445
• Tests added

[Dr-Irv]

Changes needed to use the check(assert_type(...)) pattern in new tests.

[Dr-Irv]

Thanks @refack

[refack]

We're requiring that on any new tests.

I did that, but those are suboptimal for my setup. Assignment to a type hinted variable is analyzed in PyCharm, while annotating with assert_type is transparent since the signature is assert_type(val: T_, typ: Any, /) -> T_

Both forms err for pyright/mypy.

and since syntactically the type parameter is not in a type-hint positions, we need to do the "string" trick

[Dr-Irv]

I did that, but those are suboptimal for my setup. Assignment to a type hinted variable is analyzed in PyCharm, while annotating with assert_type is transparent since the signature is assert_type(val: T_, typ: Any, /) -> T_

That's an issue with the type checker within PyCharm (which we don't support) having a different behavior than mypy and pyright . So with assert_type(), we have to surround the types that are not available at runtime (e.g., Series[int]) in quotes.