Fix memory leak in roll_quantile (#21966)

pandas-dev · Jul 19, 2018 · 27ebb3e · 27ebb3e
1 parent 3cb64bd
commit 27ebb3e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/doc/source/whatsnew/v0.23.4.txt b/doc/source/whatsnew/v0.23.4.txt
@@ -31,6 +31,7 @@ Bug Fixes
 **Groupby/Resample/Rolling**
 
 - Bug where calling :func:`DataFrameGroupBy.agg` with a list of functions including ``ohlc`` as the non-initial element would raise a ``ValueError`` (:issue:`21716`)
+- Bug in ``roll_quantile`` caused a memory leak when calling ``.rolling(...).quantile(q)`` with ``q`` in (0,1) (:issue:`21965`)
 -
 
 **Conversion**

diff --git a/pandas/_libs/window.pyx b/pandas/_libs/window.pyx
@@ -1481,6 +1481,8 @@ def roll_quantile(ndarray[float64_t, cast=True] input, int64_t win,
             else:
                 output[i] = NaN
 
+    skiplist_destroy(skiplist)
+
     return output
-Original file line number
+Diff line change
@@ Expand Up @@
                 else:
                     output[i] = NaN
+        skiplist_destroy(skiplist)
         return output
@@ Expand Down @@