BUG: constructor Timestamp.strptime() does not support %z.

pandas-dev · Feb 12, 2019 · fae65a4 · fae65a4
1 parent 4d44a2a
commit fae65a4
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/doc/source/whatsnew/v0.24.2.rst b/doc/source/whatsnew/v0.24.2.rst
@@ -66,7 +66,7 @@ Bug Fixes
 
 **Timezones**
 
--
+- Bug in :meth:`Timestamp.strptime` - support %z. (:issue:`21257`)
 -
 -
 

diff --git a/pandas/_libs/tslibs/timestamps.pyx b/pandas/_libs/tslibs/timestamps.pyx
@@ -677,6 +677,12 @@ class Timestamp(_Timestamp):
         """
         return cls(datetime.fromtimestamp(ts))
 
+    # Issue 25016. As strptime with %z is not supported in Python 2.
+    @classmethod
+    def strptime(cls, date_string, format):
+        raise NotImplementedError("Timestamp.strptime() is not implmented."
+                                  "Use to_datetime() to parse date strings.")
+
     @classmethod
     def combine(cls, date, time):
         """

diff --git a/pandas/tests/scalar/timestamp/test_timestamp.py b/pandas/tests/scalar/timestamp/test_timestamp.py
@@ -355,6 +355,14 @@ def test_constructor_invalid_tz(self):
             # interpreted as a `freq`
             Timestamp('2012-01-01', 'US/Pacific')
 
+    def test_constructor_strptime(self):
+        # GH25016
+        # Test support for Timestamp.strptime
+        fmt = '%Y%m%d-%H%M%S-%f%z'
+        ts = '20190129-235348-000001+0000'
+        with pytest.raises(NotImplementedError):
+            Timestamp.strptime(ts, fmt)
+
     def test_constructor_tz_or_tzinfo(self):
         # GH#17943, GH#17690, GH#5168
         stamps = [Timestamp(year=2017, month=10, day=22, tz='UTC'),