Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interval test skips causing other's to be skipped? #19083

Closed
TomAugspurger opened this issue Jan 4, 2018 · 3 comments
Closed

Interval test skips causing other's to be skipped? #19083

TomAugspurger opened this issue Jan 4, 2018 · 3 comments
Labels
Testing pandas testing functions or related to the test suite
Milestone

Comments

@TomAugspurger
Copy link
Contributor

Just saw this, haven't looked yet

test pass skip xfail
Interval 551 640 0
Period 472 0 1
Both 789 829 1

commands:

  • pytest pandas/tests/indexes/period/
  • pytest pandas/tests/indexes/period/
  • pytest pandas/tests/indexes/interval/ pandas/tests/indexes/period/
@TomAugspurger TomAugspurger added the Testing pandas testing functions or related to the test suite label Jan 4, 2018
@jreback
Copy link
Contributor

jreback commented Jan 4, 2018

hmm that's odd, yeah it should just be skipping the _new interval index test files.

@jreback jreback added this to the 0.23.0 milestone Jan 4, 2018
@TomAugspurger
Copy link
Contributor Author

Hmm:

pytest pandas/tests/indexes/interval/test_interval_new.py::TestIntervalIndex::test_to_series pandas/tests
/indexes/period/test_period.py::TestPeriodIndex::test_to_series -rsx
==================================================================== test session starts ====================================================================
platform darwin -- Python 3.6.1, pytest-3.3.1, py-1.5.2, pluggy-0.6.0
rootdir: /Users/taugspurger/Envs/pandas-dev/lib/python3.6/site-packages/pandas, inifile: setup.cfg
plugins: xdist-1.15.0, rerunfailures-2.2, repeat-0.4.1, cov-2.5.1, annotate-1.0.0, hypothesis-3.26.0
collected 2 items

pandas/tests/indexes/interval/test_interval_new.py s                                                                                                  [ 50%]
pandas/tests/indexes/period/test_period.py s                                                                                                          [100%]
================================================================== short test summary info ==================================================================
SKIP [2] pandas/tests/indexes/common.py: new indexing tests for issue 16316

Maybe pytest-dev/pytest#568? But that's about marking classes, not modules.

@TomAugspurger
Copy link
Contributor Author

I think we don't want to inherit from Base anyway. That'll duplicate the running of each of the base classes tests. Oh and we don't implement the expected methods like create_index anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

No branches or pull requests

2 participants