Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Implement tests for Date/TimelikeOps directly on array #24064

Closed
TomAugspurger opened this issue Dec 3, 2018 · 4 comments
Closed

TST: Implement tests for Date/TimelikeOps directly on array #24064

TomAugspurger opened this issue Dec 3, 2018 · 4 comments
Labels
Datetime Datetime data dtype Enhancement ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite

Comments

@TomAugspurger
Copy link
Contributor

followup to #24038, blocked by #24024.

Once #24024 we should move the majority of the tests hitting Date/TimelikeOps over to using the array class, and then have a few tests ensuring that the index index wrapping still works.
@TomAugspurger TomAugspurger added Testing pandas testing functions or related to the test suite Datetime Datetime data dtype ExtensionArray Extending pandas with custom dtypes or arrays. labels Dec 3, 2018
@TomAugspurger TomAugspurger added this to the Contributions Welcome milestone Dec 3, 2018
@charlesdong1991
Copy link
Member

has it been picked up? would like to work on it once the PR 24024 is finished

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Dec 4, 2018 via email

@charlesdong1991
Copy link
Member

thank you very much for your quick response @TomAugspurger , I will keep an eye on 24024, and then take a shot!

@jbrockmendel jbrockmendel mentioned this issue Dec 21, 2018
Merged
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
@jbrockmendel
Copy link
Member

the layout of the test suite is moving away from this being necessary, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Datetime Datetime data dtype Enhancement ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TomAugspurger @jbrockmendel @charlesdong1991 @mroeschke