Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Linting error #25715

Closed
hksonngan opened this issue Mar 13, 2019 · 1 comment
Closed

CI: Linting error #25715

hksonngan opened this issue Mar 13, 2019 · 1 comment

Comments

@hksonngan
Copy link
Contributor

I'm working on #25424, after rebase to upstream/master, I get linting errors.
error F632, E117 are simple fix.
error F821 is type hints as flakes8 cannot detect buildin type.
I can fix as:
a. add #noqa at the end line
b. add build in option in setup.cfg

builtins =
    _,
    _LE,
    _LW

##[error]./pandas/tests/indexes/interval/test_interval_tree.py(162,20): error F632: use ==/!= to compare str, bytes, and int literals
##[error]./pandas/tests/frame/test_alter_axes.py(204,32): error F632: use ==/!= to compare str, bytes, and int literals
##[error]./pandas/tests/frame/test_alter_axes.py(204,51): error F632: use ==/!= to compare str, bytes, and int literals
##[error]./pandas/tests/frame/test_alter_axes.py(1275,13): error E117: over-indented (comment)
##[error]./pandas/tests/io/test_pytables.py(2389,13): error E117: over-indented
##[error]./pandas/tests/series/test_rank.py(424,9): error E117: over-indented
##[error]./pandas/tests/series/test_rank.py(442,9): error E117: over-indented
##[error]./pandas/tests/series/test_rank.py(460,9): error E117: over-indented
##[error]./pandas/tests/series/test_rank.py(479,9): error E117: over-indented
##[error]./pandas/tests/series/test_rank.py(497,9): error E117: over-indented
##[error]./pandas/tests/series/test_rank.py(506,9): error E117: over-indented (comment)
##[error]./pandas/tests/series/test_rank.py(507,9): error E117: over-indented
##[error]./pandas/tests/groupby/test_grouping.py(652,13): error E117: over-indented (comment)
##[error]./pandas/tests/groupby/test_grouping.py(653,13): error E117: over-indented (comment)
##[error]./pandas/tests/groupby/test_grouping.py(654,13): error E117: over-indented (comment)
##[error]./pandas/tests/groupby/test_grouping.py(655,13): error E117: over-indented
##[error]./pandas/tests/groupby/test_apply.py(12,9): error E117: over-indented (comment)
##[error]./pandas/io/formats/format.py(443,45): error E117: over-indented (comment)
##[error]./pandas/core/frame.py(6219,33): error F821: undefined name 'Union'
##[error]./pandas/core/frame.py(6219,33): error F821: undefined name 'List'
##[error]./pandas/core/frame.py(6221,33): error F821: undefined name 'Union'
##[error]./pandas/core/frame.py(6223,9): error F821: undefined name 'Union'
##[error]./pandas/core/common.py(96,5): error F821: undefined name 'Any'
##[error]./pandas/core/base.py(789,9): error F821: undefined name 'ExtensionArray'
##[error]./pandas/core/indexes/base.py(3635,9): error F821: undefined name 'Union'
##[error]./pandas/core/dtypes/base.py(67,9): error F821: undefined name 'Optional'
##[error]./pandas/core/dtypes/base.py(67,9): error F821: undefined name 'List'
##[error]./pandas/core/dtypes/dtypes.py(940,17): error E117: over-indented
##[error]./pandas/core/arrays/sparse.py(82,9): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/sparse.py(82,9): error F821: undefined name 'Any'
##[error]./pandas/core/arrays/sparse.py(375,5): error F821: undefined name 'ndarray'
##[error]./pandas/core/arrays/sparse.py(400,5): error F821: undefined name 'Callable'
##[error]./pandas/core/arrays/sparse.py(400,5): error F821: undefined name 'Any'
##[error]./pandas/core/arrays/sparse.py(674,9): error F821: undefined name 'SparseIndex'
##[error]./pandas/core/arrays/array_.py(10,25): error F821: undefined name 'Sequence'
##[error]./pandas/core/arrays/array_.py(11,25): error F821: undefined name 'Optional'
##[error]./pandas/core/arrays/array_.py(11,25): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/array_.py(11,25): error F821: undefined name 'np'
##[error]./pandas/core/arrays/array_.py(11,25): error F821: undefined name 'ExtensionDtype'
##[error]./pandas/core/arrays/integer.py(513,9): error F821: undefined name 'ndarray'
##[error]./pandas/core/arrays/datetimelike.py(61,9): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/datetimelike.py(61,9): error F821: undefined name 'Tuple'
##[error]./pandas/core/arrays/datetimelike.py(71,9): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/datetimelike.py(71,9): error F821: undefined name 'Timestamp'
##[error]./pandas/core/arrays/datetimelike.py(71,9): error F821: undefined name 'NaTType'
##[error]./pandas/core/arrays/datetimelike.py(92,9): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/datetimelike.py(92,9): error F821: undefined name 'Timestamp'
##[error]./pandas/core/arrays/datetimelike.py(92,9): error F821: undefined name 'NaTType'
##[error]./pandas/core/arrays/datetimelike.py(112,9): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/datetimelike.py(112,9): error F821: undefined name 'Timestamp'
##[error]./pandas/core/arrays/datetimelike.py(112,9): error F821: undefined name 'NaTType'
##[error]./pandas/core/arrays/datetimelike.py(353,9): error F821: undefined name 'ndarray'
##[error]./pandas/core/arrays/datetimelike.py(463,21): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/datetimelike.py(463,21): error F821: undefined name 'Sequence'
##[error]./pandas/core/arrays/datetimelike.py(463,21): error F821: undefined name 'Sequence'
##[error]./pandas/core/arrays/datetimelike.py(464,21): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/datetimelike.py(464,21): error F821: undefined name 'NaTType'
##[error]./pandas/core/arrays/datetimelike.py(464,21): error F821: undefined name 'Scalar'
##[error]./pandas/core/arrays/datetimelike.py(464,21): error F821: undefined name 'Sequence'
##[error]./pandas/core/arrays/datetimelike.py(464,21): error F821: undefined name 'Scalar'
##[error]./pandas/core/arrays/datetimes.py(277,20): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/datetimes.py(517,9): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/period.py(183,9): error F821: undefined name 'Sequence'
##[error]./pandas/core/arrays/period.py(183,9): error F821: undefined name 'Optional'
##[error]./pandas/core/arrays/period.py(246,9): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/period.py(246,9): error F821: undefined name 'NaTType'
##[error]./pandas/core/arrays/period.py(539,22): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/period.py(539,22): error F821: undefined name 'Index'
##[error]./pandas/core/arrays/period.py(539,22): error F821: undefined name 'ExtensionArray'
##[error]./pandas/core/arrays/period.py(540,21): error F821: undefined name 'Callable'
##[error]./pandas/core/arrays/period.py(540,21): error F821: undefined name 'Any'
##[error]./pandas/core/arrays/period.py(540,21): error F821: undefined name 'Any'
##[error]./pandas/core/arrays/period.py(713,5): error F821: undefined name 'Sequence'
##[error]./pandas/core/arrays/period.py(713,5): error F821: undefined name 'Optional'
##[error]./pandas/core/arrays/period.py(713,5): error F821: undefined name 'Optional'
##[error]./pandas/core/arrays/base.py(216,9): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/base.py(216,9): error F821: undefined name 'Any'
##[error]./pandas/core/arrays/base.py(289,9): error F821: undefined name 'ExtensionDtype'
##[error]./pandas/core/arrays/base.py(297,9): error F821: undefined name 'Tuple'
##[error]./pandas/core/arrays/base.py(345,9): error F821: undefined name 'Union'
##[error]./pandas/core/arrays/base.py(368,9): error F821: undefined name 'ndarray'
##[error]./pandas/core/arrays/base.py(600,9): error F821: undefined name 'Tuple'
##[error]./pandas/core/arrays/base.py(600,9): error F821: undefined name 'ndarray'
##[error]./pandas/core/arrays/base.py(600,9): error F821: undefined name 'Any'
##[error]./pandas/core/arrays/base.py(625,9): error F821: undefined name 'Tuple'
##[error]./pandas/core/arrays/base.py(625,9): error F821: undefined name 'ndarray'
##[error]./pandas/core/arrays/base.py(728,9): error F821: undefined name 'Sequence'
##[error]./pandas/core/arrays/base.py(728,9): error F821: undefined name 'Optional'
##[error]./pandas/core/arrays/base.py(728,9): error F821: undefined name 'Any'
##[error]./pandas/core/arrays/base.py(855,9): error F821: undefined name 'Callable'
##[error]./pandas/core/arrays/base.py(855,9): error F821: undefined name 'Any'
##[error]./pandas/core/arrays/base.py(855,9): error F821: undefined name 'Optional'
##[error]./pandas/core/arrays/base.py(900,9): error F821: undefined name 'Sequence'
##[error]./pandas/core/groupby/groupby.py(1043,13): error F821: undefined name 'typing'
##[error]./pandas/core/groupby/groupby.py(1052,13): error F821: undefined name 'typing'
##[error]./pandas/core/groupby/groupby.py(1741,13): error F821: undefined name 'Optional'
##[error]./pandas/core/groupby/groupby.py(1741,13): error F821: undefined name 'typing'
##[error]./pandas/core/groupby/groupby.py(1756,13): error F821: undefined name 'Optional'
##[error]./pandas/core/groupby/groupby.py(1756,13): error F821: undefined name 'typing'
##[error]./pandas/core/internals/blocks.py(1830,9): error F821: undefined name 'Optional'
##[error]./pandas/core/internals/blocks.py(1830,9): error F821: undefined name 'BlockPlacement'
##[error]./pandas/core/internals/blocks.py(1830,9): error F821: undefined name 'Any'
##[error]./pandas/core/internals/blocks.py(1830,9): error F821: undefined name 'List'
##[error]./pandas/core/internals/managers.py(1865,5): error F821: undefined name 'List'
##[error]./pandas/core/internals/managers.py(1865,5): error F821: undefined name 'Optional'
##[error]./pandas/core/internals/managers.py(1865,5): error F821: undefined name 'Union'
##[error]./pandas/core/internals/managers.py(1865,5): error F821: undefined name 'ExtensionDtype'
Linting .py code DONE
Linting .pyx code
##[error]pandas/_libs/tslibs/nattype.pyx(356,42): error E261: at least two spaces before inline comment
@WillAyd
Copy link
Member

WillAyd commented Mar 13, 2019

If you merge master should be OK (temporarily fixed by #25701)

@WillAyd WillAyd closed this as completed Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WillAyd @hksonngan