Pinned pycodestyle

[WillAyd]

Fixes issues with the LINT failures as of recent. Quick fix with more permanent solutions split between #25697 and #25622

@TomAugspurger

[TomAugspurger]

With the latest flake8 (3.7.7) and pycodestyle=2.4.0, I get an exception

module 'pycodestyle' has no attribute 'maximum_doc_length

I'm having trouble finding which versions of flake8 are compatible with which versions of pycodestyle.

Hopefully conda is smart enough to solve these properly.

[TomAugspurger]

Ok, for reference here's what conda found

flake8                    3.6.0                    py37_0
pycodestyle               2.4.0                    py37_0
pyflakes                  2.0.0                    py37_0

and that works well.

[codecov]

Codecov Report

Merging #25701 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #25701   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files         173      173           
  Lines       52967    52967           
=======================================
  Hits        48350    48350           
  Misses       4617     4617

Flag	Coverage Δ
#multiple	89.86% <ø> (ø)	⬆️
#single	41.74% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479f821...449a0e7. Read the comment docs.

[codecov]

Codecov Report

Merging #25701 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #25701   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files         173      173           
  Lines       52967    52967           
=======================================
  Hits        48350    48350           
  Misses       4617     4617

Flag	Coverage Δ
#multiple	89.86% <ø> (ø)	⬆️
#single	41.74% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479f821...449a0e7. Read the comment docs.

[WillAyd]

@TomAugspurger all green here. Would we need to back port this as well?

[jreback]

thanks @WillAyd

yeah this needs a backport too

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

$ git checkout 0.24.x
$ git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 c57d162139c629a5e90bec6c1f336606755a0f7e

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #25701: Pinned pycodestyle'

4. Push to a named branch :

git push YOURFORK 0.24.x:auto-backport-of-pr-25701-on-0.24.x

5. Create a PR against branch 0.24.x, I would have named this PR:

"Backport PR #25701 on branch 0.24.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

[jreback]

we may need to patch https://github.com/macpython/pandas-wheels as well