Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pycodestyle Pin #25771

Closed
WillAyd opened this issue Mar 19, 2019 · 0 comments · Fixed by #25789
Closed

Remove Pycodestyle Pin #25771

WillAyd opened this issue Mar 19, 2019 · 0 comments · Fixed by #25789
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Milestone

Comments

@WillAyd
Copy link
Member

WillAyd commented Mar 19, 2019

As a temporary workaround for recent CI issues we pinned the version of pycodestyle in #25701. A good amount of these issues were caused by type comments which did not import what was needed from typing, but due to required support of Py27 at the time those imports could not be done.

With Py27 CI out, we should be able to fix this and remove the pycodestyle pin. The solution is intermixed between PRs I've already begun (#25622 and #25697) so just need to extract the required components out of them to make this a reality

@WillAyd WillAyd added CI Continuous Integration Dependencies Required and optional dependencies labels Mar 19, 2019
@WillAyd WillAyd mentioned this issue Mar 19, 2019
3 tasks
@jreback jreback added this to the 0.25.0 milestone Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants