Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python2.6 incompatibility: assertIsInstance and co #4351

Closed
yarikoptic opened this issue Jul 25, 2013 · 12 comments · Fixed by #4352
Closed

python2.6 incompatibility: assertIsInstance and co #4351

yarikoptic opened this issue Jul 25, 2013 · 12 comments · Fixed by #4352
Labels
Testing pandas testing functions or related to the test suite
Milestone

Comments

@yarikoptic
Copy link
Contributor

just got those

======================================================================
ERROR: test_banklist_header (pandas.io.tests.test_html.TestReadHtmlBase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/buildd/pandas-0.12.0/debian/tmp/usr/lib/python2.6/dist-packages/pandas/io/tests/test_html.py", line 387, in test_banklist_header
    self.assertTupleEqual(df.shape, ground_truth.shape)
AttributeError: 'TestReadHtmlBase' object has no attribute 'assertTupleEqual'

======================================================================
ERROR: test_banklist_no_match (pandas.io.tests.test_html.TestReadHtmlBase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/buildd/pandas-0.12.0/debian/tmp/usr/lib/python2.6/dist-packages/pandas/io/tests/test_html.py", line 164, in test_banklist_no_match
    self.assertIsInstance(df, DataFrame)
AttributeError: 'TestReadHtmlBase' object has no attribute 'assertIsInstance'

======================================================================
ERROR: test_gold_canyon (pandas.io.tests.test_html.TestReadHtmlBase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/buildd/pandas-0.12.0/debian/tmp/usr/lib/python2.6/dist-packages/pandas/io/tests/test_html.py", line 418, in test_gold_canyon
    self.assertIn(gc, df.to_string())
AttributeError: 'TestReadHtmlBase' object has no attribute 'assertIn'

there are more points where used... if python2.6 is no longer supported that is ok too ;)

@cpcloud
Copy link
Member

cpcloud commented Jul 25, 2013

weird i thought i removed those...

@cpcloud
Copy link
Member

cpcloud commented Jul 25, 2013

ahh i see thanks.

@cpcloud
Copy link
Member

cpcloud commented Jul 25, 2013

@yarikoptic can u pull down #4352 and make sure these work?

thanks!

@yarikoptic
Copy link
Contributor Author

Thanks!

I am building (and will install) a build of cython with 2.6 support to
my buildbot and then
http://nipy.bic.berkeley.edu/builders/pandas-py2.6-wheezy-sparc
would provide the necessary check to "make sure these work" ;)

meanwhile I have uploaded 0.12.0 to *Debian without python2.6
support

Cheers

On Wed, 24 Jul 2013, Phillip Cloud wrote:

[1]@yarikoptic can u pull down [2]#4352 and make sure these work?

thanks!


Reply to this email directly or [3]view it on GitHub.

References

Visible links

  1. https://github.com/yarikoptic
  2. TST/BUG: make sure read_html tests work on python 2.6
    TST/BUG: make sure read_html tests work on python 2.6 #4352
  3. python2.6 incompatibility: assertIsInstance and co #4351 (comment)

Yaroslav O. Halchenko, Ph.D.
http://neuro.debian.net http://www.pymvpa.org http://www.fail2ban.org
Senior Research Associate, Psychological and Brain Sciences Dept.
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419
WWW: http://www.linkedin.com/in/yarik

@jtratner
Copy link
Contributor

jtratner commented Sep 5, 2013

@yarikoptic would it be possible to have the script run python ci/versions.py (either before or after the build)? It would be helpful for debugging errors to be able to replicate the installed python packages. Also, it looks like the pandas builds are off-line and about 30 builds are queued - maybe it would make sense to cancel the earlier builds and see how many of the errors are resolved on the most recent master?

Also, are you able to set up the buildbots so that they would email me and/or other pandas core devs when they fail? It would be easier to pick up sooner.

Btw - how does the buildbot choose what to build?

@yarikoptic
Copy link
Contributor Author

Hi @jtratner -- thanks for the buzz... apparently chroots didn't come back automagically upon reboot of that box (power outage) and I haven't mentioned that so nothing was ran for the last week... it seems that pending jobs were auto-removed in favor of the most recent revision (which is good ;) ). I will look into adding printing ci/versions.py although it would have been easier if that was also a part of the interface. E.g. in pymvpa we have mvpa2.wtf() and in statsmodels we boiled down to

    post_cmds=("python -c 'from statsmodels.tools.print_version import show_versions; show_versions()'",))

which is also great since show_versions could be called on installed systems instead of seeking for ci/versions.py among original repository -- so could ci/print_versions.py be moved within pandas api?

meanwhile -- all the versions should be close to the ones on a stock wheezy/sid installation which you can check versions for at http://packages.debian.org

And meanwhile #2 here are current printouts there
wheezy

$> ci/print_versions.py 

INSTALLED VERSIONS
------------------
Python: 2.7.3.final.0
OS: Linux 2.6.32-5-sparc64-smp #1 SMP Sun May 6 09:31:16 UTC 2012 sparc64
LC_ALL: None
LANG: None

Cython: 0.19
Numpy: 1.6.2
Scipy: 0.10.1
statsmodels: 0.4.2
    patsy: Not installed
scikits.timeseries: Not installed
dateutil: 1.5
pytz: 2012c
bottleneck: Not installed
PyTables: 2.3.1
    numexpr: 2.0.1
matplotlib: 1.1.1rc2
openpyxl: 1.5.8
xlrd: 0.6.1
xlwt: 0.7.4
sqlalchemy: Not installed
lxml: 2.3.2
bs4: 4.1.0
html5lib: 0.95-dev

sid

$> ci/print_versions.py 

INSTALLED VERSIONS
------------------
Python: 2.7.5.final.0
OS: Linux 2.6.32-5-sparc64-smp #1 SMP Sun May 6 09:31:16 UTC 2012 sparc64
LC_ALL: None
LANG: None

Cython: 0.19
Numpy: 1.7.1
Scipy: 0.10.1
statsmodels: 0.4.2
    patsy: Not installed
scikits.timeseries: Not installed
dateutil: 1.5
pytz: 2012c
bottleneck: Not installed
PyTables: 2.3.1
    numexpr: 2.0.1
matplotlib: 1.1.1rc2
openpyxl: 1.6.1
xlrd: 0.6.1
xlwt: 0.7.4
sqlalchemy: Not installed
lxml: 3.2.0
bs4: 4.2.0
html5lib: 0.95-dev

and I have just installed patsy (0.2.1-1) and sqlalchemy (0.7.8-1 in wheezy and 0.8.2-1 in sid) in those chroots

@jtratner
Copy link
Contributor

jtratner commented Sep 6, 2013

@yarikoptic I'll add something to utils...would come in handy on a few of the bug reports too.

@jtratner
Copy link
Contributor

jtratner commented Sep 6, 2013

@yarikoptic (meaning - I'll add a method to print versions and move ci/versions.py)

@yarikoptic
Copy link
Contributor Author

;) good

meanwhile -- do not get surprised if current build would fail with some
obscure problems. I am updating both wheezy and sid chroots as of
speaking

On Thu, 05 Sep 2013, Jeff Tratner wrote:

[1]@yarikoptic I'll add something to utils...would come in handy on a few
of the bug reports too.

Yaroslav O. Halchenko, Ph.D.
http://neuro.debian.net http://www.pymvpa.org http://www.fail2ban.org
Senior Research Associate, Psychological and Brain Sciences Dept.
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419
WWW: http://www.linkedin.com/in/yarik

@jtratner
Copy link
Contributor

jtratner commented Sep 6, 2013

btw - do the buildbots send out emails when they fail? would be helpful to get notified so we could head the errors you find off early :)

@yarikoptic
Copy link
Contributor Author

On Thu, 05 Sep 2013, Jeff Tratner wrote:

btw - do the buildbots send out emails when they fail? would be helpful to
get notified so we could head the errors you find off early :)

wouldn't it indeed? ;) email notification is not yet set up for that
buildbot ... when I get time (or @matthew-brett) -- we should
really look into that.

Yaroslav O. Halchenko, Ph.D.
http://neuro.debian.net http://www.pymvpa.org http://www.fail2ban.org
Senior Research Associate, Psychological and Brain Sciences Dept.
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419
WWW: http://www.linkedin.com/in/yarik

@matthew-brett
Copy link
Contributor

It's a one-liner - see the end of the nibotmi master.cfg file...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants